-
Notifications
You must be signed in to change notification settings - Fork 677
SMQ-2706 - Add domain id to message topic #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
+ Coverage 27.48% 31.74% +4.25%
==========================================
Files 351 122 -229
Lines 55417 18160 -37257
==========================================
- Hits 15234 5764 -9470
+ Misses 39422 12060 -27362
+ Partials 761 336 -425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arvindh123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, except i have one comment which need testing, I will create issue for this comment
81565c6 to
45d192d
Compare
a5d6ec4 to
4160a8f
Compare
4160a8f to
ff19935
Compare
ff19935 to
f323030
Compare
9ee4a61 to
d42974a
Compare
de6c96a to
b93b3b9
Compare
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
b93b3b9 to
21facfe
Compare
|
@arvindh123 Please review this one. |
nyagamunene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@felixgateru please address comments so we can re-review. |
What type of PR is this?
This is a feature because it adds domain id to message topic.
What does this do?
/c/<channel_id>/m/<optional_subtopic>tom/<domain_id>/c/<channel_id>/<optional_subtopic>Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, tests have been updated.
Did you document any new/modified feature?
Yes, in code documentation has been updated.
Notes
None