Skip to content

Conversation

@felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Mar 20, 2025

What type of PR is this?

This is a feature because it adds domain id to message topic.

What does this do?

  • Adds domain id to message topic.
  • Refactors message topic from /c/<channel_id>/m/<optional_subtopic> to m/<domain_id>/c/<channel_id>/<optional_subtopic>
  • Updates tests for the above change
  • Adds check for domain status on channel authorization.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been updated.

Did you document any new/modified feature?

Yes, in code documentation has been updated.

Notes

None

@felixgateru felixgateru requested a review from a team as a code owner March 20, 2025 07:59
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 31.70732% with 84 lines in your changes missing coverage. Please review.

Project coverage is 31.74%. Comparing base (299cee7) to head (21facfe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
coap/adapter.go 0.00% 15 Missing ⚠️
channels/private/service.go 0.00% 9 Missing ⚠️
pkg/sdk/mocks/sdk.go 0.00% 9 Missing ⚠️
ws/handler.go 0.00% 9 Missing ⚠️
coap/api/logging.go 0.00% 7 Missing ⚠️
coap/tracing/adapter.go 0.00% 7 Missing ⚠️
pkg/messaging/message.pb.go 0.00% 5 Missing ⚠️
coap/api/metrics.go 0.00% 4 Missing ⚠️
coap/api/transport.go 0.00% 4 Missing ⚠️
ws/api/logging.go 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2765      +/-   ##
==========================================
+ Coverage   27.48%   31.74%   +4.25%     
==========================================
  Files         351      122     -229     
  Lines       55417    18160   -37257     
==========================================
- Hits        15234     5764    -9470     
+ Misses      39422    12060   -27362     
+ Partials      761      336     -425     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, except i have one comment which need testing, I will create issue for this comment

arvindh123
arvindh123 previously approved these changes Mar 20, 2025
@felixgateru felixgateru force-pushed the smq2706-domain branch 2 times, most recently from 81565c6 to 45d192d Compare March 26, 2025 11:40
@felixgateru felixgateru force-pushed the smq2706-domain branch 3 times, most recently from a5d6ec4 to 4160a8f Compare April 7, 2025 04:44
@felixgateru felixgateru changed the title SMQ-2706 - Add domain id to message topic SMQ-2706 - Add domain route to message topic Apr 7, 2025
@felixgateru felixgateru force-pushed the smq2706-domain branch 2 times, most recently from 9ee4a61 to d42974a Compare April 10, 2025 11:29
@felixgateru felixgateru changed the title SMQ-2706 - Add domain route to message topic SMQ-2706 - Add domain id to message topic Apr 10, 2025
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@dborovcanin
Copy link
Collaborator

@arvindh123 Please review this one.

Copy link
Contributor

@nyagamunene nyagamunene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arvindh123

This comment was marked as outdated.

@dborovcanin
Copy link
Collaborator

@felixgateru please address comments so we can re-review.

@dborovcanin dborovcanin merged commit 6151be7 into absmach:main Apr 11, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Domain ID to message topic

4 participants