SMQ-2785 - Disable deleting a confirmed or rejected invitation by non invitee user #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
==========================================
+ Coverage 27.55% 28.44% +0.89%
==========================================
Files 351 30 -321
Lines 55347 5456 -49891
==========================================
- Hits 15251 1552 -13699
+ Misses 39340 3809 -35531
+ Partials 756 95 -661 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arvindh123
approved these changes
May 22, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
arvindh123
approved these changes
May 22, 2025
Contributor
arvindh123
left a comment
arvindh123
left a comment
There was a problem hiding this comment.
LGTM ,
This requires changes in UI
UI Doesn't have provision to resent invitation for rejected invitations.
In UI we should disable delete button for invitations accepted
For rejected invitation we should have resend button instead of delete button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix as it fixes the following issue: #2785
What does this do?
This pr:
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have updated tests
Did you document any new/modified feature?
No
Notes