feat(config): ✨ Add excludeConvertNames in atlas-resource.json

[izcream]

Add config to make user can handle what npm_module don't need to call convertNamedImports function

I try to import axios, jsonwebtoken into atlas and compile I will got warning message on image below

then I have look up builded/bundle code module axios, jsonwebtoken was write import 'moduleName'; it's should be import moduleName from 'moduleName';

ps. not sure why rollup convert module to import 'moduleName' because function convertNamedImports was convert to right import syntax

[Timo972]

Afaik nodeJS 14+ solves cjs imports in ejs by itself, maybe it would be better to completely remove convertNamedImports.
Correct me if i'm wrong.

[izcream]

on my node js v14.18.1 and rollup ^2.60.0 axios was compile and work fine. but in atlas if I pass axios to convertNamedImports function it's do not😂 btw if remove this function my issues about import will gone true😁

[Timo972]

thats what i'm talking about, i think node 14+ does not need convertNamedImport anymore because they changed the import behaviour

[abstractFlo]

But we need this on clientside? Can anyone check this? Clientside does not run a node environment. If they can handle as well, we can remove convertNamedImportes, otherwise not ;)

[izcream]

When I try to import axios on client side it was fail to bundle its. Tonight will try without convertNameImport and update result again😅

[Timo972]

Axios will never work on clientside only alt.HttpClient

[izcream]

updated import axios,jsonwebtoken in client side with and without convertNameImports function both build failed with error message in pic below

[Timo972]

updated import axios,jsonwebtoken in client side with and without convertNameImports function both build failed with error message in pic below

you are trying to import a nodejs module on clientside which is not possible since the client script runtime is using v8.

[izcream]

But we need this on clientside? Can anyone check this? Clientside does not run a node environment. If they can handle as well, we can remove convertNamedImportes, otherwise not ;)

yes I know it cant. Just make a test result for abstracFlo comment above 😂

[izcream]

Update info from Timo and abstractFlo Look like wee don't need convertNamedImports function anymore because function was use on Serverside Config only(not found this function has use by another class on project) so. I decided to remove ConvertNamedImports function to this pull request. can someone recheck this pr?

Thanks

[abstractFlo]

I don't remove the plugin currently, i will check it by myself is it usefull to remove this. I can't accept this PR, sorry

[izcream]

Ok so can you add ability to make user choice to convertNameImport or not like my fist commit?

With this options I can solve import wrong for old npm modules😅

[abstractFlo]

Currently i have no time doing something related to altas :/ sorry

But the time is coming, i am on final stage in my current private project and if this is finished, i will push all my improvements to v3.1

[izcream]

Thanks for supporting for make v3 release. If you can fix my issues that will easy to me to handle atlas module(no need to fork and fix this myself)

edited:

The main problem is not whole convertNamedImports function another part on this function still need to have

only this sub function inside convertNamedImports make the issues happen

root.find(j.ImportDeclaration).map((path) => {
    let moduleName = path.value.source.value;
    moduleMap[moduleName] = [];

    if (moduleName.startsWith('.') || !modulesForConvert.includes(moduleName) || !path.node.specifiers.length)
      return;

    path.node.specifiers.forEach((specifier) => {
      if (specifier.type !== 'ImportSpecifier') return;

      moduleMap[moduleName].push(specifier.local.name);
    });

    j(path).replaceWith(
        `import ${!config.useStarImport ? '' : '* as'} ${pascalCase(moduleName)} from '${moduleName}';`
    );
  });

Step to reproduce this issues

---

1. import axios or jsonwebtoken module on server-side code
2. compile script (will receive rollup warning message about "default" import)
3. run altv-server and you will receive undefined axios, jsonwebtoken error

Hope you and your team can fix this issues soon, Have a nice day :)