test: Improve Vault and Zookeeper test coverage #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zookeeper: - Add zkConn interface for mocking Zookeeper connections - Add comprehensive GetValues tests (leaf nodes, children, nested) - Add watch tests (data changed, children changed, errors) - Coverage improved from 2.5% to 79.7% Vault: - Add more edge cases for flatten, getConfig, getMount, uniqMounts - Add tests for unsupported types in flatten - Add tests for getConfig with CA certs - Add tests for New() and ListSecret error cases - Coverage improved from 16.7% to 32.1% Overall coverage improved from 44.9% to 51.0% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 39.85% 45.60% +5.74%
==========================================
Files 19 19
Lines 1706 1706
==========================================
+ Hits 680 778 +98
+ Misses 955 853 -102
- Partials 71 75 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Zookeeper
zkConninterface for mocking Zookeeper connectionsVault
flatten,getConfig,getMount,uniqMountsflattengetConfigwith CA certs and invalid certsNew()andListSecreterror casesOverall project coverage improved from 44.9% to 51.0%
Test plan
go test -coverprofile🤖 Generated with Claude Code