Skip to content

Conversation

@abtreece
Copy link
Owner

@abtreece abtreece commented Jan 7, 2026

Summary

  • Migrate SSM, ACM, and DynamoDB backends from AWS SDK v1 to v2
  • Add context.Context parameter to StoreClient interface methods
  • Update all backend implementations for new interface signature
  • Remove AWS SDK v1 dependency

Closes #354

Breaking Change

The StoreClient interface now requires context.Context as the first parameter:

type StoreClient interface {
    GetValues(ctx context.Context, keys []string) (map[string]string, error)
    WatchPrefix(ctx context.Context, prefix string, keys []string, waitIndex uint64, stopChan chan bool) (uint64, error)
}

Test plan

  • All unit tests pass
  • Integration tests pass (CI will verify)
  • Test SSM backend against LocalStack
  • Test ACM backend against LocalStack
  • Test DynamoDB backend against LocalStack

🤖 Generated with Claude Code

This commit migrates all AWS backends (SSM, ACM, DynamoDB) from the
deprecated AWS SDK v1 to AWS SDK v2.

Breaking change: StoreClient interface now requires context.Context
as the first parameter for GetValues() and WatchPrefix() methods.

Changes:
- Update StoreClient interface with context.Context parameter
- Migrate SSM backend to SDK v2 with paginator pattern
- Migrate ACM backend to SDK v2 with ListCertificates paginator
- Migrate DynamoDB backend to SDK v2 with new expression syntax
- Update all non-AWS backends to accept context parameter
- Update callers in processor.go and resource.go
- Update all test files to use context.Background()

Dependencies:
- Remove: github.com/aws/aws-sdk-go v1.55.8
- Add: github.com/aws/aws-sdk-go-v2 and service packages

Closes #354
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.05%. Comparing base (c91912d) to head (4bae427).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/backends/acm/client.go 30.55% 25 Missing ⚠️
pkg/backends/ssm/client.go 46.66% 24 Missing ⚠️
pkg/backends/dynamodb/client.go 54.16% 20 Missing and 2 partials ⚠️
pkg/backends/vault/client.go 50.00% 1 Missing ⚠️
pkg/template/processor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   48.36%   48.05%   -0.31%     
==========================================
  Files          20       20              
  Lines        1863     1881      +18     
==========================================
+ Hits          901      904       +3     
- Misses        881      895      +14     
- Partials       81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abtreece abtreece merged commit 72ea4ef into main Jan 7, 2026
8 checks passed
@abtreece abtreece deleted the feat/aws-sdk-v2-migration branch January 7, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Migrate AWS backends to SDK v2

1 participant