-
Notifications
You must be signed in to change notification settings - Fork 29
adding support for numpy.ndarray and numpy.datetime64 to helpers.subsol #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like all the CI tests failed, but I was able to get most of the tests to pass in windows subsystem for linux |
Added some missing docstrings an simplified some tests.
Made a handful of PEP8 improvemeents and added a missing docstring.
Fixed unit tests that were failing on Travis due to a change in warning behaviour. Also added some missing docstrings and added more constraints to the unit tests under scrutiny.
Reverted style include whitespace around code pertaining to a block comment and ajusted line length.
Future-proofed the new doctrings.
Updated the changelog with a summary of updates in this pull request.
|
Ok @gregstarr this looks pretty good. I made some changes:
Anyway, the core elements of your contribution look great and the additional unit tests are appropriate. Before approving I need:
|
|
I added to the subsol docstring and to AUTHORS.rst but I can't get the tests to pass on Windows 10. Basically all tests fail with the error: |
|
Ok, since that problem is not related to this PR, I am going to merge it in. |
Same as #27 except between develop branches