Skip to content

Expand unit test coverage#22

Merged
aburrell merged 4 commits intodevelopfrom
expand_unit_test_coverage
Mar 16, 2026
Merged

Expand unit test coverage#22
aburrell merged 4 commits intodevelopfrom
expand_unit_test_coverage

Conversation

@aburrell
Copy link
Owner

@aburrell aburrell commented Mar 16, 2026

Description

Fixes #5, #6, and #7 by either removing inaccessible lines, adding new tests, or removing support for the older versions of SciPy.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran unit tests locally, with debug statements to check for increased coverage.

Test Configuration

  • Operating system: OS X Tahoe
  • Version number: Python 3.10
  • Any details about your local setup that are relevant: scipy 1.14.1

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My commits are formatted appropriately (following the SciPy/NumPy style)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.md, summarising the changes
  • Add yourself to .zenodo.json

Check the logic, and I can't see how this line could ever be reached.  The only way to enter the if-loop that encases it is to have a condition that will set the first value in `sweep_times`.
Removed the support for older versions of scipy.
Added unit tests for intensity distributions that have poorly defined equatorward and poleward boundaries.
Added a summary of changes to the changelog.
@aburrell aburrell added this to the 0.2.0 milestone Mar 16, 2026
@aburrell aburrell merged commit d5ab8b8 into develop Mar 16, 2026
63 of 64 checks passed
@aburrell aburrell deleted the expand_unit_test_coverage branch March 16, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Improve coverage on get_auroral_slice BUG: Improve coverage for get_gaussian_func_fit BUG: Improve coverage for find_intensity_boundaries

1 participant