Superschema + some post-alpha schema changes#14
Merged
Conversation
… multiple types and simplifies parsing
Maximilian-Staab
previously requested changes
Jul 28, 2020
Contributor
Maximilian-Staab
left a comment
There was a problem hiding this comment.
Just minor things. One copy-paste error and some suggestions to the new OpenService type.
Co-authored-by: MaximilianS <maximilian.staab@mailbox.org>
Co-authored-by: MaximilianS <maximilian.staab@mailbox.org>
| @@ -27,15 +27,10 @@ | |||
| "enum": ["OpenService"] | |||
| }, | |||
| "Service": { | |||
Contributor
There was a problem hiding this comment.
I would have expected an approach more to eg. WithTrafficStats or WithDestination.
Contributor
There was a problem hiding this comment.
I started implementing the Service shared type and would like to propose that. Do you know of a way to add a MR to a MR xD?
Contributor
There was a problem hiding this comment.
Example
xarf_shared
"Service": {
"type": "object",
"description": "Specify a service to report",
"required": ["ServiceName"],
"properties": {
"ServiceName": {
"type": "string"
},
"ServiceVersion": {
"type": "string",
"description": "Affected service version or version range"
}
}
},
"TransportProtocol": {
"type": "object",
"description": "Transport protocol used by the reportee",
"properties": {
"TransportProtocol": {
"type": "string",
"enum": ["tcp", "udp"]
}
}
}Usage
{
"$ref": "xarf_shared.schema.json#/TransportProtocol"
},
{
"$ref": "xarf_shared.schema.json#/Service"
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new versioning mechanism. Old versions and the current development preview are always part of the "superschema". This makes it simpler for parser software to be able to parse multiple versions of XARF.
Summary:
schemas/now contains one subfolder per version including the latest development preview indevelopmentsamples/now contains apositiveandnegativesubfolder and each of them contains one sample folder per versionVersionhas to be set in all new versions, it is not required foralphaalphacontains all work so far and the version that currently some organizations are already using. no incompatible changes have been performeddevelopmentshould not be used in production. It is unstable and always contains the changes that will be introduced in the next version