Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the HMRC Other Deductions API version 2.0, enabling interaction with endpoints for managing other deductions data in the UK's Making Tax Digital system.
- Adds new API endpoint definitions for Other Deductions (amend, get, delete operations)
- Introduces new error handling for ship name format validation
- Updates documentation to include the new API support
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mtd-hmrc-err.c | Adds error mapping for ship name format validation |
| src/api_endpoints.h | Defines Other Deductions API configuration and endpoint structures |
| include/libmtdac/mtd.h | Adds enum values for new error type, API, and endpoints |
| docs/man/man3/libmtdac_mtd.h.3 | Updates man page with new API definitions and date |
| docs/man/man3/libmtdac.3 | Adds Other Deductions API documentation reference |
| docs/libmtdac_mtd.h.3.rst | Updates RST documentation with new API definitions |
| docs/libmtdac.3.rst | Adds Other Deductions API documentation link |
| README.rst | Updates API list to include Other Deductions with version 2.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Link: <https://developer.service.hmrc.gov.uk/api-documentation/docs/api/service/other-deductions-api/2.0/oas/page> Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link: https://developer.service.hmrc.gov.uk/api-documentation/docs/api/service/other-deductions-api/2.0/oas/page