Conversation
Check the result of the fstatat(2) to see if we got a non-directory path component. This would really only be a problem if the *last* component wasn't a directory as otherwise the mkdirat(2) will catch it. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull Request Overview
Adds a check to ensure path components are directories when creating directory hierarchies. This prevents the mkdir_p() function from attempting to create directories when a non-directory file exists in the path.
- Validates that existing path components are directories using
S_ISDIR()macro - Sets appropriate error code (
ENOTDIR) and exits early when encountering non-directory components - Improves error handling for edge cases in directory creation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the result of the fstatat(2) to see if we got a non-directory path component.
This would really only be a problem if the last component wasn't a directory as otherwise the mkdirat(2) will catch it.