Conversation
Link: <https://developer.service.hmrc.gov.uk/api-documentation/docs/api/service/individuals-capital-gains-income-api/2.0/oas/page> Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Individuals Capital Gains Income API (version 2.0) to the library, enabling handling of residential property disposals and other capital gains/disposals.
- Adds new API endpoint definitions for capital gains income operations
- Extends error code mappings to include new HMRC validation rules specific to capital gains
- Updates documentation to reference the new API
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mtd-hmrc-err.c | Adds error code mappings for capital gains validation rules and format errors |
| src/api_endpoints.h | Defines API metadata and endpoint configurations for residential property disposals and other gains operations |
| include/libmtdac/mtd.h | Adds error code enums and API endpoint identifiers for the new ICGI API |
| docs/man/man3/libmtdac_mtd.h.3 | Updates generated man page documentation with new enums and changes header date |
| docs/man/man3/libmtdac.3 | Adds API reference link to documentation and updates header date |
| docs/libmtdac_mtd.h.3.rst | Updates RST source documentation with new error codes and endpoint enums |
| docs/libmtdac.3.rst | Adds new API entry with link to HMRC documentation |
| README.rst | Adds Individuals Capital Gains Income API to supported APIs table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link: https://developer.service.hmrc.gov.uk/api-documentation/docs/api/service/individuals-capital-gains-income-api/2.0/oas/page