Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes macro definition issues by adding proper parenthesization to ensure correct operator precedence in C preprocessor macros. The changes address potential bugs where macros could be expanded incorrectly when used in expressions with other operators.
Changes:
- Added parentheses around multi-line bitwise OR macros (MTD_OPT_ALL, _FPH_COMMON, and related macros)
- Fixed operator precedence in macros combining multiple bitwise operations (FPH_WEB_APP_VIA_SERVER, FPH_BATCH_PROCESS_DIRECT)
- Added parentheses around function-like macro expressions (SET_FPH_FUNC, MTD_FPH_SET_FUNC)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mtd.c | Removed redundant parentheses around MTD_OPT_ALL in bitwise operation |
| src/fph.c | Added proper parenthesization to all FPH flag macros and fixed SET_FPH_FUNC macro |
| include/libmtdac/mtd.h | Added parentheses to MTD_OPT_ALL multi-line macro and MTD_FPH_SET_FUNC macro |
| docs/man/man3/libmtdac_mtd.h.3 | Auto-generated documentation update reflecting code changes and updated date |
| docs/libmtdac_mtd.h.3.rst | Auto-generated documentation update reflecting code changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Otherwise things like (flags & ~MTD_OPT_ALL) go awry. In mtd.c we did ~(MTD_OPT_ALL) but this commit is the right way to do it and will avoid nasty surprises for other users. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
Similar to the previous commit, this is the right way to do it. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.