Reduce duplication in endpoints[] #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the API endpoints have the same .authz and .scope values. Extend and rename the api_version_map[] array to now be a set of default values for an endpoint API. Move it into api_endpoints.h where it's better suited and we can then create a couple of inline helper functions for getting the right .authz and .scope values. We check the endpoints array first for the .authz and .scope values, if they aren't set we grab one or both values from this new array. This allows to remove most of the .authz and .scope initialisers from endpoints[]. We leave the OAuth entries as they are slightly different. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the API endpoints have the same .authz and .scope values.
Extend and rename the api_version_map[] array to now be a set of default values for an endpoint API. Move it into api_endpoints.h where it's better suited and we can then create a couple of inline helper functions for getting the right .authz and .scope values.
We check the endpoints array first for the .authz and .scope values, if they aren't set we grab one or both values from this new array.
This allows to remove most of the .authz and .scope initialisers from endpoints[]. We leave the OAuth entries as they are slightly different.