fix: include [dev] extras in install-dev to fix make test for new contributors#167
fix: include [dev] extras in install-dev to fix make test for new contributors#167
Conversation
…tributors Fixes #154. The install-dev target was installing a manual, incomplete list of packages that omitted pytest-timeout, pytest-xdist, pytest-cov, and respx. Since pyproject.toml configures --timeout=120 via addopts, running make test immediately after make install-dev failed with "unrecognized arguments: --timeout=120". Replace the manual list with the [dev] extras group so all test dependencies are installed in one pip invocation and kept in sync with pyproject.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the developer install workflow so make install-dev pulls test/dev tooling from the project’s declared [dev] extras, aiming to make make test work in a fresh environment.
Changes:
- Replace the manual
pip install pytest pytest-asyncio rufflist with installing thedevextras. - Consolidate
install-devinto a single editable install invocation includingdev.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| install-dev: | ||
| pip install -e ".[server,langchain,pydantic-ai,crewai]" | ||
| pip install pytest pytest-asyncio ruff | ||
| pip install -e ".[server,langchain,pydantic-ai,crewai,dev]" |
There was a problem hiding this comment.
Fixed. Added a server optional-dependencies group to pyproject.toml (commit 907d5fa) containing the FastAPI server deps (fastapi, uvicorn[standard], sqlalchemy[asyncio], aiosqlite, alembic, aiofiles, bcrypt), mirroring the dependencies from pyproject-server.toml. This means pip install -e ".[server,...]" in both install and install-dev now actually resolves and installs server deps. All 2350 tests pass.
…stalls server deps The Makefile install-dev target referenced .[server,...] but pyproject.toml had no server optional-dependency group defined, causing pip to silently skip all server deps (fastapi, uvicorn, sqlalchemy, etc.). This made make install-dev followed by make test fail for new contributors. Adds the server extra mirroring the dependencies from pyproject-server.toml (minus the peaky-peek self-reference). Also fixes the install target which had the same issue. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
make install-devomittingpytest-timeout,pytest-xdist,pytest-cov, andrespxfrom the dev installpip install -e ".[server,langchain,pydantic-ai,crewai,dev]"invocationmake install-dev && make testwithout hittingunrecognized arguments: --timeout=120Closes #154
Test plan
make install-devin a fresh virtualenv succeedsmake testpasses aftermake install-dev(no--timeout=120error)ruff check .passes (confirmed locally: all checks passed)🤖 Generated with Claude Code