VD-3016: add repo and CI guardrails (obot)#22
Merged
Conversation
revive's context-as-argument rule fails the go workflow on every PR and push to main; a permanently red check cannot become a required check. Part of VD-3016 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- go.yml: unique lint-go check name (three jobs were named lint), no paths filters and ready_for_review trigger so the required check reports on every PR, including upstream-sync drafts made with GITHUB_TOKEN whose events start no workflows - test.yaml, verify-sync-metadata.yml: same ready_for_review trigger - build-vibedata-image.yml: pin provider FROM inputs to the digests the pre-check verified instead of :latest, which can move between the check and the pull - .github/rulesets/main-branch.json: versioned ruleset (PR + 1 approval, required checks lint-go/test/verify, no force-push or deletion) - CLAUDE.md: CI gates, fail-closed publish contract, local verification Part of VD-3016 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hbanerjee74
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of VD-3016 (with accelerate-data/providers#6 — the issue closes when both merge).
Adds the repo/CI guardrails that make this fork's image a reliable Studio release input. The
main-branch-protectionruleset is already applied live (required checkslint-go/test/verify, PR + 1 approval, no force-push/deletion); this PR lands the workflow changes those required check names come from, and is itself the proof they report and pass.Changes
gocheck — revivecontext-as-argumentinmcpcatalog_sync_test.go(context param order in two test helpers). Package tests pass 32/32. A required check cannot be permanently red.go.yml— job display namelint-go(three jobs across workflows were namedlint; required checks match by check-run name), removed PRpaths-ignoreso the required check reports on every PR, addedready_for_reviewtrigger.test.yaml,verify-sync-metadata.yml—ready_for_reviewtrigger. Upstream-sync drafts are created withGITHUB_TOKEN, whose events start no workflows; without this, required checks never report on sync PRs and they can never merge.build-vibedata-image.yml— providerFROMinputs pinned to the digests the pre-check verified instead of:latest, which can move between the check and the pull..github/rulesets/main-branch.json— the applied ruleset, versioned in-repo.CLAUDE.md— CI gates, fail-closed publish contract, failure ownership, local verification commands.Verification
go test ./pkg/controller/handlers/mcpcatalog/— 32 passedactionlintclean on all changed workflows (one pre-existing SC2086 info in an untouched step)ready_for_reviewtriggers🤖 Generated with Claude Code