Skip to content

Add type check job to actions#778

Merged
chvp merged 1 commit intomainfrom
chore/type-check
Apr 25, 2026
Merged

Add type check job to actions#778
chvp merged 1 commit intomainfrom
chore/type-check

Conversation

@chvp
Copy link
Copy Markdown
Member

@chvp chvp commented Apr 25, 2026

Prep for #772, since there are a few different issues with that bump.

@chvp chvp self-assigned this Apr 25, 2026
@chvp chvp added the chore Repository or build maintenance label Apr 25, 2026
@chvp chvp requested a review from robbevp as a code owner April 25, 2026 11:48
@chvp chvp force-pushed the chore/type-check branch 2 times, most recently from f087af7 to d96919c Compare April 25, 2026 11:55
@chvp chvp enabled auto-merge (squash) April 25, 2026 11:56
Copy link
Copy Markdown
Member

@robbevp robbevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe also want to change the build script to tsc && vite build? If you generate a new vite setup with typescript, that is the build command that would be included by default

@chvp chvp force-pushed the chore/type-check branch from d96919c to f3dbcbf Compare April 25, 2026 12:49
@chvp chvp requested a review from robbevp April 25, 2026 12:49
@chvp
Copy link
Copy Markdown
Member Author

chvp commented Apr 25, 2026

Do we maybe also want to change the build script to tsc && vite build? If you generate a new vite setup with typescript, that is the build command that would be included by default

Done

Copy link
Copy Markdown
Member

@robbevp robbevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chvp chvp merged commit 247640b into main Apr 25, 2026
4 checks passed
@chvp chvp deleted the chore/type-check branch April 25, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Repository or build maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants