feat: add skeleton loading state to CreatorProfileStatRow (#206)#219
Open
temisan0x wants to merge 1 commit intoaccesslayerorg:mainfrom
Open
feat: add skeleton loading state to CreatorProfileStatRow (#206)#219temisan0x wants to merge 1 commit intoaccesslayerorg:mainfrom
temisan0x wants to merge 1 commit intoaccesslayerorg:mainfrom
Conversation
|
@temisan0x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated skeleton loading state to
CreatorProfileStatRowto prevent layout shift during data hydration.Changes
src/components/ui/skeleton.tsx— new reusable Skeleton primitive (animate-pulse+bg-white/[0.08])src/components/common/CreatorProfileStatRow.tsx— addedisLoadingandskeletonCountprops; skeleton mirrors exact dimensions and classes ofCreatorProfileStatItemsrc/components/common/__tests__/CreatorProfileStatRow.test.tsx— new tests covering loaded state, skeleton state, and placeholder card countTest results
KeySupplyBadge.test.tsxare pre-existing (confirmed onmainbaseline: 7 failed before this PR, now 5)Validation
Closes #206