feat: add empty holdings illustration alt text accessibility pass#250
Open
jessicanath wants to merge 1 commit intoaccesslayerorg:mainfrom
Open
feat: add empty holdings illustration alt text accessibility pass#250jessicanath wants to merge 1 commit intoaccesslayerorg:mainfrom
jessicanath wants to merge 1 commit intoaccesslayerorg:mainfrom
Conversation
- mark illustration as decorative with alt="" and aria-hidden="true" - add role="status" + aria-label on the container so screen readers announce the empty state title without duplicating the image - add aria-label on Reset Search CTA for explicit action labeling - add aria-hidden on decorative RotateCcw icon Closes accesslayerorg#171
|
@jessicanath Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves accessibility for empty holdings visuals by adding clear alt text and semantic labeling.
Changes
EmptyState: illustration image is now marked as decorative (alt="",aria-hidden="true") — the title text already describes the state, so the image should not be announced redundantlyrole="status"andaria-label={title}on the container so screen readers announce the empty state correctlyaria-label="Reset search results"on the CTA button for explicit action labelingaria-hidden="true"on the decorativeRotateCcwiconTesting
pnpm lint)tsc -b)Closes #171