fix(admin): add dry-run mode for indexer replay#203
Merged
Conversation
skip audit-event writes when dryRun=true to avoid side effects. validate dryRun payload and document maintainer usage. Closes accesslayerorg#188 Made-with: Cursor
|
@wheval Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dryRunoption toPOST /admin/indexer/replaywith strict boolean validationdryRun=trueto guarantee no write side effectsTest plan
/admin/indexer/replaywith{ \"startLedger\": 123456, \"dryRun\": true }returns success withdryRun: true/admin/indexer/replaywithdryRun=false(or omitted) still writes audit eventdryRunvalue (e.g. string) returns 400 validation errorCloses #188