refactor(map): deduplicate hover/glow logic and extract timeout constant#883
Merged
alanhargreaves merged 1 commit intoaccius:Stagingfrom Apr 6, 2026
Merged
Conversation
- Add POPUP_AUTO_CLOSE_MS = 20_000 module-level constant; replace the two inline 20000 literals in bindSpotClick - Add bindHoverGlow(marker, latlng, color, markersRef) useCallback that owns all mouseover/mouseout popup + glow logic: uses a Leaflet glow ring for SVG circleMarkers (this._path) and a CSS drop-shadow filter for divIcon markers (this._icon), auto-detected at event time - Replace ~150 lines of repeated inline mouseover/mouseout handlers across DX circles, DX labels, POTA/SOTA/WWFF/WWBOTA markers and labels, PSK Reporter TX+RX, and WSJT-X with a single bindHoverGlow() call each Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included