Skip to content

[refactor] fixes issue #948 nit fix /api/health_lockdown redundant ternary#953

Merged
accius merged 2 commits into
accius:Stagingfrom
MichaelWheeley:#948_nit_fix_api_health_lockdown
May 6, 2026
Merged

[refactor] fixes issue #948 nit fix /api/health_lockdown redundant ternary#953
accius merged 2 commits into
accius:Stagingfrom
MichaelWheeley:#948_nit_fix_api_health_lockdown

Conversation

@MichaelWheeley
Copy link
Copy Markdown
Contributor

What does this PR do?

basic validation performed,

  • http://localhost:3001/api/health
  • http://localhost:3001/api/health?key=password
  • curl -i http://localhost:3001/api/health
  • curl -i http://localhost:3001/api/health?key=password

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor / code cleanup
  • Documentation
  • Translation
  • Map layer plugin

@MichaelWheeley MichaelWheeley marked this pull request as ready for review May 4, 2026 23:48
Copy link
Copy Markdown
Owner

@accius accius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified: the entire object inside ...(isAuthed ? {...} : {}) is gated, so the inner isAuthed ? a : b ternaries on persistence, sessions, and pskMqttProxy.activeCallsigns were dead branches — the unauthenticated arms were unreachable. Removing them is a strict simplification with no behavior change for either authed or unauthed callers. Consolidating the SECURITY comment up top reads well too.

@accius accius merged commit 813178b into accius:Staging May 6, 2026
4 checks passed
@MichaelWheeley MichaelWheeley deleted the #948_nit_fix_api_health_lockdown branch May 6, 2026 19:53
@accius accius mentioned this pull request May 7, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants