[refactor] fixes issue #948 nit fix /api/health_lockdown redundant ternary#953
Merged
accius merged 2 commits intoMay 6, 2026
Merged
Conversation
…ion that guarantees isAuthed === true
accius
approved these changes
May 6, 2026
Owner
accius
left a comment
There was a problem hiding this comment.
LGTM. Verified: the entire object inside ...(isAuthed ? {...} : {}) is gated, so the inner isAuthed ? a : b ternaries on persistence, sessions, and pskMqttProxy.activeCallsigns were dead branches — the unauthenticated arms were unreachable. Removing them is a strict simplification with no behavior change for either authed or unauthed callers. Consolidating the SECURITY comment up top reads well too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
isAuthed ? {...} : {...}inside outer condition that guaranteesisAuthed === truebasic validation performed,
http://localhost:3001/api/healthhttp://localhost:3001/api/health?key=passwordcurl -i http://localhost:3001/api/healthcurl -i http://localhost:3001/api/health?key=passwordType of change