Skip to content

Issue951 maidenhead grid to utils geo#964

Merged
accius merged 12 commits into
accius:Stagingfrom
MichaelWheeley:issue951_maidenhead_grid_to_utils_geo
May 10, 2026
Merged

Issue951 maidenhead grid to utils geo#964
accius merged 12 commits into
accius:Stagingfrom
MichaelWheeley:issue951_maidenhead_grid_to_utils_geo

Conversation

@MichaelWheeley
Copy link
Copy Markdown
Contributor

closes #951

  • previously there were multiple sources of Maidenhead grid locator helper code
  • all code now points to (client side) utils/geo.js, or to (server side) utils/grid.js
  • remove @hamset/maidenhead-locator (in package.json)
  • instances of parseGridSquare converted to maidenheadToLatLon
  • add missing reference to maidenheadToLatLon in src\plugins\layers\useN3FJPLoggedQSOs.js
  • remove unused references to maidenheadToLatLon in server\routes\propagation.js and server\routes\pskreporter.js
  • instances of calculateGridSquare converted to latLonToMaidenhead
  • duplicate Maidenhead grid content of src\utils\geo.js into server\utils\grid.js - the two cannot easily share a common source since the export patterns of the server (CommonJS) and client (ESM) are different.
  • remove duplicate functionality maidenheadToLatLon from `server\routes\callsign.js
  • point server existing uses of maidenheadToLatLon to server\utils\grid.js
  • replace isValidGrid with validateGridLocator
  • remove multiple versions of gridToLatLon from server and client, point existing use of gridToLatLon to respective maidenheadToLatLon versions in util (server or client). Note, /rig-bridge/** not modified.
  • Global removal and replacement of latLonToGrid with latLonToMaidenhead. Note, /AddOns/APRS-AutoPos/aprs_autopos.user.js not modified.
  • remove unused parseGridSquare
  • remove unused calculateGridSquare

Type of change

  • Bug fix
  • New feature
  • Performance improvement
  • Refactor / code cleanup
  • Documentation
  • Translation
  • Map layer plugin

Checklist

  • App loads without console errors
  • Tested in Dark, Light, and Retro themes
  • Responsive at different screen sizes (desktop + mobile)
  • If touching server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)
  • If adding an API route: includes caching and error handling
  • If adding a panel: wired into Modern, Classic, and Dockable layouts
  • No hardcoded colors — uses CSS variables (var(--accent-cyan), etc.)
  • No .bak, .old, console.log debug lines, or test scripts included

@accius accius merged commit 141b262 into accius:Staging May 10, 2026
4 checks passed
accius added a commit that referenced this pull request May 10, 2026
…pre-Hamvention banner

Folds the four post-26.3.1 Staging merges (#936 MeshCom, #960 update.sh
npm ci, #964 grid consolidation, #967 satellite audit) into the 26.3.2
features list and rewrites the entries in plainer language for the
production audience. Announcement banner now leads with the surprise
hotfix-and-feature drop ahead of Hamvention 2026.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@MichaelWheeley MichaelWheeley deleted the issue951_maidenhead_grid_to_utils_geo branch May 10, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants