Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Conversation

sahalsaad
Copy link
Contributor

Closes #50

Changes

  • Implement link copied message in HyperlinkModal

Flags

Screenshots or Video

image

Related Issues

Author Checklist

  • Vital features and changes captured in unit and/or integration tests
  • [/ ] Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@jolanglinais
Copy link
Member

Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit. For more information see how this works.

Signed-off-by: Sahal Saad <caalshift@gmail.com>
@sahalsaad sahalsaad force-pushed the sahal/50/link-coppied-message branch from b1d3821 to 42be14b Compare October 5, 2020 17:20
@sahalsaad
Copy link
Contributor Author

Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit. For more information see how this works.

Updated with sign off commit. Thanks

Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @Michael-Grover?

Copy link

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@jolanglinais jolanglinais merged commit 8eb645e into accordproject:master Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display a message in hyperlink modal to indicate that the link is copied

3 participants