Skip to content

Conversation

@natacha-beck
Copy link
Contributor

This pull request contain the files for the release 2.5.0. It was necessary to add 'pako' under /lib in order to include this library in the minify version.

@natacha-beck
Copy link
Contributor Author

@rdvincent Can you take a look to this one. It is the fix for the pako library.

@rdvincent
Copy link

@natacha-beck sorry, the previous code seemed to work ok - so does this just add pako.js so that it gets included in brainbrowser-*.min.js?

@natacha-beck
Copy link
Contributor Author

Yes exactly, if I do not do that it do not go to the minify version so it
didn't work properly when people use the minify version only.

On 20 June 2016 at 14:06, Robert D Vincent notifications@github.com wrote:

@natacha-beck https://github.com/natacha-beck sorry, the previous code
seemed to work ok - so does this just add pako.js so that it gets included
in brainbrowser-*.min.js?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#309 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAvddlZ8FssDklYKlZulwOkuRj0Ez1y4ks5qNtaIgaJpZM4I5RSx
.

@natacha-beck
Copy link
Contributor Author

For example on our website.

On 20 June 2016 at 14:10, Natacha Beck natabeck@gmail.com wrote:

Yes exactly, if I do not do that it do not go to the minify version so it
didn't work properly when people use the minify version only.

On 20 June 2016 at 14:06, Robert D Vincent notifications@github.com
wrote:

@natacha-beck https://github.com/natacha-beck sorry, the previous code
seemed to work ok - so does this just add pako.js so that it gets included
in brainbrowser-*.min.js?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#309 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAvddlZ8FssDklYKlZulwOkuRj0Ez1y4ks5qNtaIgaJpZM4I5RSx
.

@rdvincent rdvincent merged commit 6fe1fe2 into aces:master Jun 20, 2016
@natacha-beck natacha-beck deleted the release_2.5.0_fix branch July 5, 2016 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants