Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the CI/CD pipeline configuration by adding parallel jobs and enabling push events on the main branch, as well as updating the justfile environment variable and dependency logic.
- Added push trigger for main branch and separated CI tasks into distinct jobs (build, format, lint, and test)
- Updated environment variable usage to GABBER_CI and adjusted npm dependency steps in various jobs
Files not reviewed (1)
- justfile: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/ci.yaml:49
- [nitpick] Consider using consistent naming for tool installation steps across jobs. Both the Build and Format jobs use 'Setup tools', while the Lint job uses 'Install tools'.
- name: Install tools
.github/workflows/ci.yaml:68
- [nitpick] The step name 'Install just' may be misleading as it installs both just and Firefox; consider renaming it to 'Install dependencies' for clarity.
- name: Install just
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the CI/CD pipeline by adding parallel jobs to build, format, lint, and test the project, and updates the justfile configuration to use a new environment variable.
- Introduces separate jobs for build, format, lint, and test processes running on macos-latest.
- Adds support for push events on the main branch and configures environment-specific setup steps.
Files not reviewed (1)
- justfile: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the CI/CD pipeline configuration and the
justfile. The changes aim to enhance the build, format, lint, and test processes.CI/CD Pipeline Enhancements:
.github/workflows/ci.yaml: Added new jobs for build, format, lint, and test processes, and configured them to run onmacos-latest. Thepushevent is now triggered for themainbranch. Environment variables and setup steps for tools and dependencies were also added.Updates to
justfile:justfile: Changed the environment variable fromCItoGABBER_CIand updated the logic forswiftlint_reporterandcodesigning.justfile: Removed the_deps-npmdependency fromcheck-lint-npmandcheck-format-othertargets. [1] [2] [3]