Skip to content

ci: parallelize and run on main#11

Merged
acidghost merged 3 commits intomainfrom
feat/ci/parallelize
Apr 1, 2025
Merged

ci: parallelize and run on main#11
acidghost merged 3 commits intomainfrom
feat/ci/parallelize

Conversation

@acidghost
Copy link
Copy Markdown
Owner

This pull request includes significant updates to the CI/CD pipeline configuration and the justfile. The changes aim to enhance the build, format, lint, and test processes.

CI/CD Pipeline Enhancements:

  • .github/workflows/ci.yaml: Added new jobs for build, format, lint, and test processes, and configured them to run on macos-latest. The push event is now triggered for the main branch. Environment variables and setup steps for tools and dependencies were also added.

Updates to justfile:

  • justfile: Changed the environment variable from CI to GABBER_CI and updated the logic for swiftlint_reporter and codesigning.
  • justfile: Removed the _deps-npm dependency from check-lint-npm and check-format-other targets. [1] [2] [3]

@acidghost acidghost added the ci label Apr 1, 2025
@acidghost acidghost requested a review from Copilot April 1, 2025 10:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the CI/CD pipeline configuration by adding parallel jobs and enabling push events on the main branch, as well as updating the justfile environment variable and dependency logic.

  • Added push trigger for main branch and separated CI tasks into distinct jobs (build, format, lint, and test)
  • Updated environment variable usage to GABBER_CI and adjusted npm dependency steps in various jobs
Files not reviewed (1)
  • justfile: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/ci.yaml:49

  • [nitpick] Consider using consistent naming for tool installation steps across jobs. Both the Build and Format jobs use 'Setup tools', while the Lint job uses 'Install tools'.
      - name: Install tools

.github/workflows/ci.yaml:68

  • [nitpick] The step name 'Install just' may be misleading as it installs both just and Firefox; consider renaming it to 'Install dependencies' for clarity.
      - name: Install just

Comment thread .github/workflows/ci.yaml
@acidghost acidghost added the enhancement New feature or request label Apr 1, 2025
@acidghost acidghost requested a review from Copilot April 1, 2025 10:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the CI/CD pipeline by adding parallel jobs to build, format, lint, and test the project, and updates the justfile configuration to use a new environment variable.

  • Introduces separate jobs for build, format, lint, and test processes running on macos-latest.
  • Adds support for push events on the main branch and configures environment-specific setup steps.
Files not reviewed (1)
  • justfile: Language not supported

@acidghost acidghost merged commit ad6c935 into main Apr 1, 2025
4 checks passed
@acidghost acidghost deleted the feat/ci/parallelize branch April 1, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants