Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Update the CI workflow to remove manual installation of Firefox ESR and rely on the runner’s pre-installed browser.
- Removed the
brew install --cask firefox@esrcommand from the Setup build tools step. - Streamlines CI by using the GitHub-hosted runner’s pre-installed Firefox.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yaml:68
- [nitpick] Consider adding a comment above this step to explain that Firefox is now pre-installed on the GitHub Actions runner, so the manual installation was removed.
- name: Setup build tools
.github/workflows/ci.yaml:70
- [nitpick] You might add a quick version check (e.g.,
firefox --version) after this step to verify the pre-installed Firefox version meets your requirements.
brew install just
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.