build: exclude the whole deps/ directory from the cargo workspace#2
Merged
Conversation
The pull_request-gated `test` job runs `cargo test --workspace`, which includes the vendored forks under deps/ as implicit path-dep workspace members. `ffmpeg-sidecar` fails all its tests with os error 2 because they spawn the `ffmpeg` binary, which is not installed on the runner; the `pingora-*` crates are a self-contained upstream fork. Exclude both from the test run (mirrors the existing deps/lance and deps/lancedb workspace exclusions). First-party crates are unaffected; `staticflow-pingora-gateway` (our gateway crate) does not match the `pingora*` glob and is still tested. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Supersedes the per-command CI `--exclude` from the previous commit (reverted here). Excluding `deps` in the root workspace manifest makes `cargo test/clippy/fmt --workspace` all skip the vendored forks uniformly, not just the single CI test command. This extends the existing deps/lance + deps/lancedb exclusions to the whole deps/ dir: ffmpeg-sidecar spawns the ffmpeg binary (absent on the runner) and the pingora-* crates are a self-contained upstream fork. First-party crates still depend on them via path deps (gateway -> pingora, shared -> lance, ...). Cargo.lock regenerated: 108 packages removed (all pingora-exclusive dev/build deps + the pingora crates), 0 added, and no first-party crate's dependency version changed - the 24 'version-set' shrinks only drop pingora's old duplicate majors (hyper 0.14, reqwest 0.11, rustls 0.21, ...). cargo metadata --locked passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
acking-you
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo test/clippy/fmt --workspacedescend into the vendored forks underdeps/, which are implicit path-dependency workspace members. Two of thembreak or don't belong in this project's checks:
ffmpeg-sidecarfails all its tests withos error 2because they spawn theffmpegbinary, which is not installed on CI runners.pingora-*crates are a self-contained upstream fork (their own nestedworkspace), not ours to lint/format/test.
What changed
Exclude the whole
deps/directory from the workspace in the rootCargo.toml, extending the existingdeps/lance+deps/lancedbexclusions:This is more complete than excluding individual crates from a single CI
command: every
--workspace/--allinvocation (test, clippy, fmt — CI andlocal) now skips
deps/uniformly. First-party crates still depend on theforks via path deps (
gateway→ pingora,shared→ lance, ...); excluding adirectory only removes workspace membership, not the dependency edges.
Cargo.lockis regenerated as a result: 108 packages removed (allpingora-exclusive dev/build deps + the pingora crates), 0 added, and no
first-party crate's dependency version changed — the 24 "version-set" shrinks
only drop pingora's old duplicate majors (
hyper 0.14,reqwest 0.11,rustls 0.21, ...).cargo metadata --lockedpasses.First step of an incremental
llm-access*refactor: a green, trustworthy CIbaseline before the refactor PRs.