Fix handling of dots in mapping names

[ackkerman]

Summary

• correctly parse mappings whose subdirectory or remote names contain dots
• test dotted mapping to ensure pull works

Testing

• cargo test

---

https://chatgpt.com/codex/tasks/task_e_68995dde3a788330b2be6a28edd5848e

[gemini-code-assist]

Summary of Changes

Hello @ackkerman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed an issue where gh-sync was unable to correctly parse configuration entries for repository mappings that contained dots in their names. This change ensures that mapping names with dots are now properly recognized and handled, allowing operations like pull to function as expected for such mappings. I've also included a new test case to validate this fix.

Highlights

• Configuration Parsing Fix: I've updated the Config::load method in src/config.rs to correctly parse configuration keys for mappings that include dots in their names. Previously, the parsing logic incorrectly split mapping names at every dot, leading to issues when names like tools/automaton.x were used. The fix involves using strip_prefix and rsplit_once to ensure that the mapping name is correctly identified, even if it contains dots.
• New Integration Test: I've added a new integration test, dotted_subdir_and_remote, in tests/cli.rs. This test specifically verifies that gh-sync can successfully connect to and pull a repository whose subdirectory and remote names contain dots. This ensures that the parsing fix works as expected and prevents regressions for this specific scenario.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue with parsing mapping names that contain dots. The previous implementation incorrectly split the configuration key, while the new implementation uses rsplit_once to correctly separate the mapping name from the field. A new test case has been added to verify this fix. My review includes a suggestion to refactor the new test to reduce code duplication and improve maintainability.

[gemini-code-assist]

This test is great for covering the dotted name case. However, there's some code duplication in setting up the Command. You can refactor this to improve readability and maintainability by using a closure to create and configure the command.

    let get_cmd = || {
        let mut cmd = Command::cargo_bin("gh-sync").unwrap();
        cmd.current_dir(repo.path())
            .env("PATH", &path_env)
            .env("ORIG_PATH", &orig_path);
        cmd
    };

    get_cmd()
        .args(&[
            "connect",
            "tools/automaton.x",
            "git@github.com:a/automaton.x.git",
        ])
        .assert()
        .success();

    get_cmd()
        .args(&["pull", "tools/automaton.x"])
        .assert()
        .success();