Remove SIGURG blocking from maybe_grow_with to restore preemptive scheduling on grown stacks#429
Merged
Merged
Conversation
…uling on grown stacks Agent-Logs-Url: https://github.com/acl-dev/open-coroutine/sessions/20b581e3-30f1-4e74-b014-4d33795a3902 Co-authored-by: loongs-zhang <38336731+loongs-zhang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix signal mask restoration in OnStackGuard
Remove SIGURG blocking from maybe_grow_with to restore preemptive scheduling on grown stacks
Mar 31, 2026
loongs-zhang
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe_grow_withwas blocking SIGURG for the entire duration ofcorosensei::on_stack(), which completely disables preemptive scheduling while on a grown stack. Any dead loop inside the callback becomes uninterruptible.thread_block/thread_set_maskaroundon_stack()callOnStackGuardto only handlestack_infoscleanup (still needed for unwind safety)Before:
After: