Fixes for crypto, byte ranges, and wrapping jsfetch urls #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Diff of diffs, great :) I'm happy you manage to get deep enough to get all of those internals exposed! That's super cool.
|
* Properly prepend http/https URLs with `jsfetch:`. This is to address situations where the m3u8 was pre-pended with `jsfetch:` but the M3U8 contains absolute URLs. Since those start with i.e `http://`, ffmpeg can't fetch them. * Add support for byte ranges in jsfetch * Add `ffmpeg_get_out_time_ms` and `ffmpeg_get_out_time_ms` for progress tracking * Add `ffmpeg_interrupt` to abort a running download * Add the patch from [https://trac.ffmpeg.org/ticket/7359](https://trac.ffmpeg.org/ticket/7359) which address issues with seeking HLS streams. This patch is not in ffmpeg 7.1.1 release
camgaertner
force-pushed
the
ffmpeg-cli-poc
branch
from
d5ecbb0 to
f0bfe1a
Compare
Member
|
(let me know if this needs a review) |
Member
|
Won't be using this PR. See https://github.com/aclap-dev/vdh/pull/254 Keeping this open as reference. |
camgaertner
changed the title
paulrouget
reviewed
Aug 4, 2025
| --enable-demuxer=flv | ||
| --enable-demuxer=dash | ||
| --enable-libxml2 | ||
| --enable-muxer=hls |
Member
There was a problem hiding this comment.
Not saying it's wrong, but I'm surprised it's here (enable-muxer=hls).
Member
|
Good with me. Go ahead and merge. |
paulrouget
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things.
jsfetch:to HLS urls in the manifest that need it. When downloading from an m3u8 via i.ejsfetch:https://example.com/test.m3u8, if that m3u8 contained absolute URIs, they would not be properly fetched w/ jsfetch.