Skip to content
This repository was archived by the owner on Aug 3, 2025. It is now read-only.

Conversation

@sameetandpotatoes
Copy link
Member

  • Rewritten in ruby
  • Consolidate three users tables to 1 with two flags (is_member, added_to_directory)

Done

  • Login flow
  • Migration script

TODO

  • Hookup to AD script, change table names
  • Write tests (probably another PR)
  • Refactor auth.rb to be a bit more dry

@narendasan
Copy link
Member

Is this WIP or are you looking to merge now? Because it seems like with out the ad script this isn't fully functional

@sameetandpotatoes
Copy link
Member Author

Yeah I guess WIP, as right now AD script isn't working anyways so we need to get that working too, probably in conjunction with this

@sameetandpotatoes sameetandpotatoes changed the title Refactor [WIP] Refactor Feb 13, 2017
@sameetandpotatoes sameetandpotatoes changed the title [WIP] Refactor Refactor Feb 20, 2017
@sameetandpotatoes sameetandpotatoes merged commit ba14c93 into master Feb 20, 2017
@sameetandpotatoes sameetandpotatoes deleted the refactor branch February 20, 2017 00:49
@bcongdon
Copy link
Member

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants