-
Notifications
You must be signed in to change notification settings - Fork 0
Improvements to development docker-compose setup #46
Conversation
|
@sameetandpotatoes: I think we can use |
|
how do we deploy this (like removing the -u flag)? |
|
|
This can be merged as-is. The work to add live-reloading to Ruby / Node / Go services can be tracked in separate issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, lgtm otherwise
| - db | ||
| - groot-api-gateway | ||
| volumes: | ||
| - ./groot-users-service:/usr/src/app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add RACK_ENV=development to the ruby services? Or is development assumed by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Development is the default
-uflag on api-gateway to not require gateway authentication while doing dev workThis can be merged as-is, but if we want full live-reload support we'll need:
Additionally, we'll need to patch the Dockerfiles for Ruby services to move
wait-for-itout of the application source directory. See acm-uiuc/groot-users-service#15 for an exampleRuby service dockerfiles needing patch: