You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.
Hi,
Thanks @Kisbogyi , this is a great improvement. I'd love to see it merged.
This change could fix the shellcheck:
CHALLENGE=$(grep Www "$HTTP_HEADER" | sed 's/Www-Authenticate: Basic realm=//g' | sed 's/[^a-zA-Z0-9\/\.\-]//g')
_H2="Authorization: Basic $(cat "$CHALLENGE")"
(Also fix a typo.)
Another thing: the tokens are in "/var/opt/azcmagent/tokens/" and not all users have access to it so acme.sh may need to be run by root for this scenario.
Hi, Thanks @Kisbogyi , this is a great improvement. I'd love to see it merged. This change could fix the shellcheck:
CHALLENGE=$(grep Www "$HTTP_HEADER" | sed 's/Www-Authenticate: Basic realm=//g' | sed 's/[^a-zA-Z0-9\/\.\-]//g')
_H2="Authorization: Basic $(cat "$CHALLENGE")"
(Also fix a typo.)
Another thing: the tokens are in "/var/opt/azcmagent/tokens/" and not all users have access to it so acme.sh may need to be run by root for this scenario.
Hi!
Sorry for the late response it was hectic for me, my bad.
I incorporated your change for the pr, but may need help for the tests :(
Again sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code will enable the azure module to work in Azure arc servers as well, because azure arc servers use a separate url, and method for the challenge/response protocol.
https://learn.microsoft.com/en-us/azure/azure-arc/servers/managed-identity-authentication