Skip to content

Conversation

@arukuka
Copy link
Member

@arukuka arukuka commented Aug 22, 2022

Summary

  • Partially handle unexpected error on CC

Purpose

  • When an unexpected error (ex. SIGSEGV) was occured in CC,
    there are few debug information.
  • This patch will solve this issue partially.

Contents

  • Add wrapper script for lauching CC
  • Add core dump file setting script for maintainer
    • This patch is checked that it works in Linux environment

Testing Methods Performed

  • run SIGSEGV code
    diff --git a/src/ComputationContainer/Job/JobBase.hpp b/src/ComputationContainer/Job/JobBase.hpp
    index 2b6cc5c4..373de8c4 100644
    --- a/src/ComputationContainer/Job/JobBase.hpp
    +++ b/src/ComputationContainer/Job/JobBase.hpp
    @@ -166,6 +166,11 @@ public:
             {
                 auto [share_table, schemas] = readDb();
                 validate_cols(schemas, arg);
    +            if (schemas.size())
    +            {
    +                int *ptr = nullptr;
    +                *ptr = 1;
    +            }
                 auto result = static_cast<T *>(this)->compute(share_table, schemas, arg);
                 writeDb(result);
             }
  • Use wrapper script
    diff --git a/Test/docker-compose.yml b/Test/docker-compose.yml
    index 836c98d9..bd868add 100644
    --- a/Test/docker-compose.yml
    +++ b/Test/docker-compose.yml
    @@ -32,7 +32,7 @@ services:
         depends_on:
           dev_bts:
             condition: service_healthy
    -    command: ["/bin/bash", "-c", "printenv && ./computation_container"]
    +    command: ["/bin/bash", "-c", "printenv && ./Scripts/wrapped_run.sh ./computation_container"]
         healthcheck:
           test: [
               "CMD-SHELL",
    @@ -73,7 +73,7 @@ services:
         networks:
           shared-network:
             ipv4_address: 10.0.2.20
    -    command: ["/bin/bash", "-c", "printenv && ./computation_container"]
    +    command: ["/bin/bash", "-c", "printenv && ./Scripts/wrapped_run.sh ./computation_container"]
         healthcheck:
           test: [
               "CMD-SHELL",
    @@ -114,7 +114,7 @@ services:
         networks:
           shared-network:
             ipv4_address: 10.0.3.20
    -    command: ["/bin/bash", "-c", "printenv && ./computation_container"]
    +    command: ["/bin/bash", "-c", "printenv && ./Scripts/wrapped_run.sh ./computation_container"]
         healthcheck:
           test: [
               "CMD-SHELL",
  • check log with docker logs computation_container1
  • check that core dump file can be copied with docker cp computation_container1:/tmp/cores /

@arukuka arukuka force-pushed the feature/otsuka/add_wrapper_scripts_for_cc branch from 44ca8df to 46e570e Compare November 25, 2022 03:40
@arukuka arukuka marked this pull request as ready for review November 25, 2022 04:25
@mdonaka mdonaka merged commit e7b6a87 into main Nov 25, 2022
@mdonaka mdonaka deleted the feature/otsuka/add_wrapper_scripts_for_cc branch November 25, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants