Skip to content

Conversation

@mdonaka
Copy link

@mdonaka mdonaka commented Oct 7, 2022

Summary

Add new DB to CC

Purpose

Delete couchbase

Contents

  • Add storage DB
    • small stage: bind
    • dev stage: volumes
  • Add method for new DB on CC

Testing Methods Performed

  • make test t=ComputationContainer p=small
  • temporarily switch DB and request from libClient
  • CI

Step

  1. Add method on MC
  2. [now] Add method on CC
  3. Switch DB and test with libClient
  4. Delete old DB

@mdonaka mdonaka requested review from arukuka and come2ry October 7, 2022 12:06
@mdonaka mdonaka marked this pull request as ready for review October 11, 2022 03:29
Copy link
Member

@arukuka arukuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I commented on the part that I was curious about, so please check it.

Copy link
Member

@arukuka arukuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mdonaka mdonaka force-pushed the feature/nakata/new_db_cc branch from a79a00c to d521d7b Compare October 11, 2022 08:41
@arukuka
Copy link
Member

arukuka commented Oct 12, 2022

@mdonaka I beg your pardon, #50 was merged, please rebase this pr.

@mdonaka mdonaka force-pushed the feature/nakata/new_db_cc branch from d521d7b to 51003fd Compare October 12, 2022 03:10
@mdonaka
Copy link
Author

mdonaka commented Oct 12, 2022

@arukuka
Thank you! I rebased it.
I'll merge it when CI passes.

@arukuka arukuka merged commit aae459f into main Oct 12, 2022
@arukuka arukuka deleted the feature/nakata/new_db_cc branch October 12, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants