Skip to content

Conversation

@mdonaka
Copy link

@mdonaka mdonaka commented Oct 11, 2022

Summary

Remove pipenv

Purpose

Fix libClient test

Contents

  • Remove pipenv from libClient Dockerfile

Testing Methods Performed

  • make test t=LibClient p=medium
  • CI

Details

The following changes were made Pipenv version 2022.10.9.

  • When you create a pipenv project with a python version, the following two items are written to the Pipfile
    • python_version
    • python_full_version

ref: Pipenv release note

However, the following error occurs when trying to install the module as is.

python_full_version: 'python_version' must not be present with 'python_full_version'
python_version: 'python_full_version' must not be present with 'python_version'

wow... Really? I don't understand... So I remove Pipenv.

@mdonaka mdonaka requested review from arukuka and come2ry October 11, 2022 07:28
@mdonaka mdonaka marked this pull request as ready for review October 11, 2022 07:34
@mdonaka mdonaka merged commit 54bf6d4 into main Oct 11, 2022
@mdonaka mdonaka deleted the fix/nakata/libClient_pipenv branch October 11, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants