Skip to content

Conversation

@arukuka
Copy link
Member

@arukuka arukuka commented Nov 14, 2022

Summary

  • Use smart pointer instead of handling raw pointer

Purpose

  • prevent memory leak

Contents

  • bb708fa Use std::unique_ptr instead of new

Testing Methods Performed

  • Run progress_demo.py 3~5 times with N=10,000, valgrind --tool=massif when launching CC
  • Run CC small, medium test

@arukuka arukuka force-pushed the feature/otsuka/use_smart_ptr branch from bb708fa to 1f836e3 Compare November 14, 2022 04:53
Copy link

@mdonaka mdonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great changes!
This is a minute thing, but please check two points.

@arukuka arukuka requested a review from mdonaka November 14, 2022 06:53
@arukuka
Copy link
Member Author

arukuka commented Nov 14, 2022

@mdonaka I changed code, and check that small, medium test are passed at local.
Please review again.

@arukuka arukuka merged commit a091f14 into main Nov 14, 2022
@arukuka arukuka deleted the feature/otsuka/use_smart_ptr branch November 14, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants