Skip to content

Conversation

@mdonaka
Copy link

@mdonaka mdonaka commented Nov 17, 2022

Summary

Fix hjoin progress

Purpose

Check progress correctly with the progress bar

Contents

  • Add comment
  • Further split blocks for biased data

Let block_size=3, v1=[1, 2, 3, 4, 5], v2=[1, 4, 6, 7, 9].
The original implementation had block1=[[1,2,3],[4,5]], block2=[[1], [4,6,7,9]].
Since [4,6,7,9] in block2 exceeded block_size, progress also exceeded 100%.
Therefore, block2 is further divided.
After the change, it will be block1=[[1,2,3],[4,5],[4,5]], block2=[[1],[4,6,7],[9]].

Testing Methods Performed

  • run hjoin for biased data with block_size set to 3
  • CI

@mdonaka mdonaka marked this pull request as ready for review November 17, 2022 05:59
@mdonaka mdonaka merged commit 2eecabe into main Nov 17, 2022
@mdonaka mdonaka deleted the fix/nakata/fix_hjoin_progress branch November 17, 2022 07:20
@mdonaka mdonaka mentioned this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants