Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

@yashgiri
Copy link
Contributor

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in paranthesis, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keyworkds that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

This PR replaces use of aws ecr images to ghcr images.
Relevant tests have been modified.
Agreed with Craig on the idea that ghcr token expiring is fine.

Signed-off-by: Yashgiri Goswami <yashgirigoswami1@gmail.com>
@yashgiri yashgiri marked this pull request as ready for review March 27, 2023 08:29
@yashgiri yashgiri requested a review from tylerslaton March 27, 2023 08:32
Signed-off-by: Yashgiri Goswami <yashgirigoswami1@gmail.com>
Signed-off-by: Yashgiri Goswami <yashgirigoswami1@gmail.com>
@yashgiri
Copy link
Contributor Author

Hi @tylerslaton I have updated those entries. Now all images that i could find are in ghcr.

@yashgiri yashgiri requested a review from tylerslaton March 27, 2023 21:46
@cjellick cjellick mentioned this pull request Mar 27, 2023
7 tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is in this file:

FROM nginx as static

And I think this is referring to the nginx:latest image in Docker Hub, since there isn't another FROM statement with the nginx alias given to it. So that image should be changed as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, great point @g-linville.

Signed-off-by: Yashgiri Goswami <yashgirigoswami1@gmail.com>
@yashgiri yashgiri requested a review from cjellick March 28, 2023 16:00
@yashgiri yashgiri merged commit 2fd5f49 into acorn-io:main Mar 28, 2023
@yashgiri yashgiri deleted the newimages branch March 28, 2023 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants