Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

fix acorn run --update behavior to allow --name flag (#1444 #1457) #1445

Merged
merged 1 commit into from
Apr 7, 2023
Merged

fix acorn run --update behavior to allow --name flag (#1444 #1457) #1445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,10 @@ func (s *Run) Run(cmd *cobra.Command, args []string) error {
if s.Interactive {
return fmt.Errorf("cannot use --update/-u or --replace/-r with --dev/-i")
}
return updateHelper(cmd, args, s, c, isDir, cwd)
//if app does not exist but --update/--replace flag is used create app instead
if existingApp != nil {
return updateHelper(cmd, args, s, c, isDir, cwd)
}
}

if s.Interactive {
Expand Down
2 changes: 0 additions & 2 deletions pkg/cli/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,6 @@ func TestRun(t *testing.T) {
Spec: apiv1.InfoSpec{},
},
}, nil)
f.EXPECT().ImageDetails(gomock.Any(), gomock.Any(), gomock.Any()).Return(
nil, fmt.Errorf("error: app image-dne does not exist"))
},
},
{
Expand Down