Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

@jsilverio22
Copy link
Contributor

@jsilverio22 jsilverio22 commented Apr 5, 2023

Checklist

This PR changes the behavior when a user does acorn run --update -n app_name prior if the app did not exist an error would be thrown, after the behavior will be that a new app w/ name app_name will be created

@jsilverio22 jsilverio22 self-assigned this Apr 5, 2023
@jsilverio22 jsilverio22 changed the title fix acorn run --update behavior to allow --name flag fix acorn run --update behavior to allow --name flag (#1444) Apr 5, 2023
@jsilverio22 jsilverio22 marked this pull request as ready for review April 5, 2023 23:00
Signed-off-by: Joshua Silverio <joshua@acorn.io>
@jsilverio22 jsilverio22 force-pushed the update-create branch 2 times, most recently from c86087f to 7c93a17 Compare April 6, 2023 01:59
@jsilverio22 jsilverio22 changed the title fix acorn run --update behavior to allow --name flag (#1444) fix acorn run --update behavior to allow --name flag (#1444, #1448) Apr 6, 2023
@jacobdonenfeld
Copy link
Contributor

Is allowing --name flag with --update covered in tests?

@jsilverio22
Copy link
Contributor Author

Is allowing --name flag with --update covered in tests?

from the hub e2e I believe so

@jsilverio22 jsilverio22 merged commit 567b9dc into acorn-io:main Apr 7, 2023
@jsilverio22 jsilverio22 deleted the update-create branch April 7, 2023 16:16
@jsilverio22 jsilverio22 changed the title fix acorn run --update behavior to allow --name flag (#1444, #1448) fix acorn run --update behavior to allow --name flag (#1444) Apr 7, 2023
@jsilverio22 jsilverio22 changed the title fix acorn run --update behavior to allow --name flag (#1444) fix acorn run --update behavior to allow --name flag (#1444 #1457) Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants