Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

retry for eks test #1553

Merged
merged 1 commit into from
Apr 26, 2023
Merged

retry for eks test #1553

merged 1 commit into from
Apr 26, 2023

Conversation

@jsilverio22
Copy link
Contributor

@jsilverio22 jsilverio22 commented Apr 26, 2023

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

tylerslaton
tylerslaton approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

@tylerslaton
Copy link
Contributor

tylerslaton commented Apr 26, 2023

Looks like CI is red for a linting issue.

@jsilverio22
retry for eks test
3162196 
Signed-off-by: Joshua Silverio <joshua@acorn.io>
@jsilverio22 jsilverio22 merged commit 88cf1a8 into acorn-io:main Apr 26, 2023
@jsilverio22 jsilverio22 deleted the eks-retry branch April 26, 2023 23:56
jacobdonenfeld pushed a commit to jacobdonenfeld/acorn that referenced this pull request May 2, 2023
@jsilverio22 @jacobdonenfeld
retry for eks test (acorn-io#1553)
b7b78de 
Signed-off-by: Joshua Silverio <joshua@acorn.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thedadams thedadams Awaiting requested review from thedadams

2 more reviewers

@StrongMonkey StrongMonkey StrongMonkey approved these changes

@tylerslaton tylerslaton tylerslaton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsilverio22 @tylerslaton @StrongMonkey