-
Notifications
You must be signed in to change notification settings - Fork 3
Reorganize page for Acquire Zarr #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here are my comments from looking through the dev site: I'd like to remove all references to "Acquire Imaging" from the front page and menu bar. Filling out the "how to cite" section would be nice. I (just) added a zenodo doi (see acquire-project/acquire-zarr#56). Looking at the "Guides" section of the front page:
Looking at the "Getting started" content:
acquire-zarr is both a C library and a python library. Where we refer to the library in python-specific contexts, I'd like to qualify that we're talking about the python acquire-zarr library. For example in the installation instructions on the front page, it should say something like "to install the acquire-zarr python library, |
|
OOps! I was pretty sure I had fixed the examples links, will double check. Will address your other feedback today. I can manually add the citation from Zenodo, but would you like to also have a citation.cff file in the repo? |
|
@aliddell do we have install/linking instructions for the c library anywhere? They would look something like:
|
I would! I just added one to acquire-project/acquire-zarr#56 |
Questions for @aliddell:
|
|
I've just updated the preview with the feedback above, except for some copy around building the C library from source. One question I have is that we have set up versioning for these docs, but now that the focus is changing from acquire-python to acquire-zarr, we may need to re-deploy the versions to match the acquire-zarr versions. Once we've settled on the versioning any maintainer can run the appropriate commands (which are described here https://acquire-project.github.io/acquire-docs/stable/for_contributors/update_version/) |
|
|
New feedback on the Get Start Page. In the current arrangement, the Python and C content is mixed together and out of order. To fix this:
|
Yeah, on the acquire-zarr repo our only instructions are for building from source. I added a suggestion for getting started. |
|
Yay! We are nearly done with the docs. Below are the remaining items:
@melissawm please tag me and Alan in a comment once these changes are live. I am so excited to be wrapping up this docs work! |
aliddell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a few suggestions for you.
Co-authored-by: Alan Liddell <alan.c.liddell@gmail.com>
Co-authored-by: Alan Liddell <alan.c.liddell@gmail.com>
This will need to be done after this PR is merged, as it will take re-deploying the site so the new organization needs to go in first.
Please let me know if I forgot anything. Here is the preview for the latest changes: https://melissawm.github.io/acquire-docs/stable/ |
This PR reorganizes the contents of the website to focus on acquire-zarr.
A few changes to take note:
Preview here: https://melissawm.github.io/acquire-docs/dev/