Skip to content

fix: error messages don't stacktrace for 'recoverable' tracer errors#183

Merged
drmorr0 merged 1 commit intomasterfrom
drmorr/sk-22-tracer-shouldnt-fail-on-missing-permissions
Apr 25, 2025
Merged

fix: error messages don't stacktrace for 'recoverable' tracer errors#183
drmorr0 merged 1 commit intomasterfrom
drmorr/sk-22-tracer-shouldnt-fail-on-missing-permissions

Conversation

@drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Apr 25, 2025

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

If there are pods that show up that are owned by something that sk-tracer doesn't have permissions to watch, previously it would stacktrace and make it look like the program had crashed. This should still be an error, but let's not make it stacktrace since sk-tracer can keep going with other events.

Testing done

  • manual testing

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.49%. Comparing base (353dc49) to head (9440256).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sk-store/src/watchers/mod.rs 0.00% 8 Missing ⚠️
sk-store/src/watchers/pod_watcher.rs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   70.67%   70.49%   -0.19%     
==========================================
  Files          57       57              
  Lines        3267     3274       +7     
  Branches     3267     3274       +7     
==========================================
- Hits         2309     2308       -1     
- Misses        787      794       +7     
- Partials      171      172       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drmorr0 drmorr0 merged commit f712955 into master Apr 25, 2025
6 of 7 checks passed
@drmorr0 drmorr0 deleted the drmorr/sk-22-tracer-shouldnt-fail-on-missing-permissions branch April 25, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments