Conversation
Contributor
Author
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 70.49% 70.38% -0.11%
==========================================
Files 57 57
Lines 3274 3313 +39
Branches 3274 3313 +39
==========================================
+ Hits 2308 2332 +24
- Misses 794 810 +16
+ Partials 172 171 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
88230ed to
867b102
Compare
867b102 to
5ecf76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Some custom resources let you specify multiple podSpecTemplates that aren't necessarily in an "array" format; so this lets you just define multiple podSpecTemplatePaths as a list in the tracer config.
The old field is officially deprecated, but we can't just delete it because it will break parsing of old trace files, and I don't really want to release SKv3 over this change, so we just do a fairly straightforward migration when we load the config.
Testing done
make test; add new tests for the deprecated fieldsAdditional info
Also updated docs and example trace files