Skip to content

Drmorr/sk 35 add skip local volume mount flag to cli#190

Merged
drmorr0 merged 3 commits intomasterfrom
drmorr/sk-35-add-skip-local-volume-mount-flag-to-cli
May 15, 2025
Merged

Drmorr/sk 35 add skip local volume mount flag to cli#190
drmorr0 merged 3 commits intomasterfrom
drmorr/sk-35-add-skip-local-volume-mount-flag-to-cli

Conversation

@drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented May 14, 2025

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

  • --skip-local-volume-mount CLI flag
  • specify arbitrary driver args in the simulation spec
  • fix nextest cached files location

Testing done

  • manual testing
  • adding tests for build volume mounts and build driver job args

@drmorr0
Copy link
Contributor Author

drmorr0 commented May 14, 2025

Kubernetes Object DAG

%%{init: {'themeVariables': {'mainBkg': '#ddd'}}}%%
graph LR

classDef default color:#000
subgraph global
  direction LR
  global/simkube[<b>Namespace</b><br>simkube]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-tracer
  direction LR
  simkube/sk-tracer-svc[<b>Service</b><br>sk-tracer-svc]
  simkube/sk-tracer-depl[<b>Deployment</b><br>sk-tracer-depl]
  simkube/sk-tracer-sa[<b>ServiceAccount</b><br>sk-tracer-sa]
  sk-tracer/sk-tracer-crb[<b>ClusterRoleBinding</b><br>sk-tracer-crb]
  simkube/sk-tracer-tracer-config[<b>ConfigMap</b><br>sk-tracer-tracer-config]
  simkube/sk-tracer-sa--->simkube/sk-tracer-depl
  sk-tracer/sk-tracer-crb--->simkube/sk-tracer-depl
  simkube/sk-tracer-tracer-config--->simkube/sk-tracer-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-ctrl
  direction LR
  simkube/sk-ctrl-depl[<b>Deployment</b><br>sk-ctrl-depl]
  simkube/sk-ctrl-sa[<b>ServiceAccount</b><br>sk-ctrl-sa]
  sk-ctrl/sk-ctrl-crb[<b>ClusterRoleBinding</b><br>sk-ctrl-crb]
  simkube/sk-ctrl-sa--->simkube/sk-ctrl-depl
  sk-ctrl/sk-ctrl-crb--->simkube/sk-ctrl-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

global--->sk-tracer
global--->sk-ctrl

%% STYLE DEFINITIONS START
%% STYLE DEFINITIONS END
Loading

New object
Deleted object
Updated object
Updated object (causes pod recreation)

Detailed Diff

@drmorr0 drmorr0 force-pushed the drmorr/sk-35-add-skip-local-volume-mount-flag-to-cli branch from 19fafc1 to f92f5f7 Compare May 14, 2025 20:33
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 69.69697% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.49%. Comparing base (75a928f) to head (223ecfe).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
sk-ctrl/src/objects.rs 79.31% 12 Missing ⚠️
sk-cli/src/run.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   74.01%   71.49%   -2.52%     
==========================================
  Files          58       58              
  Lines        3225     3263      +38     
  Branches      156      162       +6     
==========================================
- Hits         2387     2333      -54     
- Misses        733      814      +81     
- Partials      105      116      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drmorr0 drmorr0 force-pushed the drmorr/sk-35-add-skip-local-volume-mount-flag-to-cli branch from f92f5f7 to 969d6c4 Compare May 14, 2025 22:06
@drmorr0 drmorr0 force-pushed the drmorr/sk-35-add-skip-local-volume-mount-flag-to-cli branch from 969d6c4 to 223ecfe Compare May 14, 2025 22:18
@drmorr0 drmorr0 merged commit f5e72cb into master May 15, 2025
8 of 9 checks passed
@drmorr0 drmorr0 deleted the drmorr/sk-35-add-skip-local-volume-mount-flag-to-cli branch May 15, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments