Skip to content

bump fireconfig to v0.5.5#202

Merged
ogorman89 merged 1 commit intomasterfrom
chore/acrl-204/bump-fireconfig-v0.5.5
Sep 10, 2025
Merged

bump fireconfig to v0.5.5#202
ogorman89 merged 1 commit intomasterfrom
chore/acrl-204/bump-fireconfig-v0.5.5

Conversation

@ogorman89
Copy link
Contributor

@ogorman89 ogorman89 commented Sep 10, 2025

  • [ X ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

bumps fireconfig from v0.5.4 -> v0.5.5

Testing done

  • How did you test your changes? Automated testing
  • Does this code require any new tests to be written? No

Additional info

Resolves acrl-204

@ogorman89 ogorman89 self-assigned this Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.34%. Comparing base (713ffeb) to head (d021739).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          58       58           
  Lines        3253     3253           
  Branches      160      160           
=======================================
  Hits         2451     2451           
  Misses        698      698           
  Partials      104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogorman89 ogorman89 marked this pull request as ready for review September 10, 2025 04:30
@ogorman89 ogorman89 requested a review from drmorr0 September 10, 2025 04:30
Copy link
Contributor

@drmorr0 drmorr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick: I try to follow conventional commits for simkube, and then I have some tooling to autogenerate a changelog based on the commit prefixes. Can you rename the commit message here to chore: bump fireconfig...

@drmorr0
Copy link
Contributor

drmorr0 commented Sep 10, 2025

minor nitpick: I try to follow conventional commits for simkube, and then I have some tooling to autogenerate a changelog based on the commit prefixes. Can you rename the commit message here to chore: bump fireconfig...

Or I guess maybe build(deps) instead of chore, since that's what dependabot is using for its other stuff...

@ogorman89
Copy link
Contributor Author

I just noticed the "Comment on the PR" workflow failed to run. I think its the same permissions issue for 3rd party workflows but I noted it in ACRL-205

@ogorman89 ogorman89 force-pushed the chore/acrl-204/bump-fireconfig-v0.5.5 branch from 0fae5c4 to d021739 Compare September 10, 2025 21:37
@ogorman89 ogorman89 merged commit 15439dd into master Sep 10, 2025
8 checks passed
@ogorman89 ogorman89 deleted the chore/acrl-204/bump-fireconfig-v0.5.5 branch September 10, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments