Skip to content

don't hard-crash on owner lookup failure#203

Merged
drmorr0 merged 1 commit intomasterfrom
drmorr/fix-unable-to-lookup-owners
Sep 15, 2025
Merged

don't hard-crash on owner lookup failure#203
drmorr0 merged 1 commit intomasterfrom
drmorr/fix-unable-to-lookup-owners

Conversation

@drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Sep 15, 2025

Related Links

What

  • Export now works even if the owned objects are inaccessible
  • The logging messages are readable

Why

Bugfixes

Test Steps

What are all the steps to testing your code changes?

  • Manual testing

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

@drmorr0 drmorr0 force-pushed the drmorr/fix-unable-to-lookup-owners branch from 1cb3c36 to 3455fc6 Compare September 15, 2025 20:11
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.14%. Comparing base (2f7e448) to head (e9da31b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sk-store/src/manager.rs 0.00% 10 Missing ⚠️
sk-store/src/store.rs 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   75.34%   75.14%   -0.21%     
==========================================
  Files          58       58              
  Lines        3253     3263      +10     
  Branches      160      161       +1     
==========================================
+ Hits         2451     2452       +1     
- Misses        698      706       +8     
- Partials      104      105       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drmorr0 drmorr0 force-pushed the drmorr/fix-unable-to-lookup-owners branch from 3455fc6 to e9da31b Compare September 15, 2025 20:21
@drmorr0 drmorr0 merged commit b5cd865 into master Sep 15, 2025
6 of 7 checks passed
@drmorr0 drmorr0 deleted the drmorr/fix-unable-to-lookup-owners branch September 15, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments