Skip to content

ACRL-303: chore: add zizmor#233

Merged
drmorr0 merged 1 commit intomainfrom
drmorr/zizmor
Mar 31, 2026
Merged

ACRL-303: chore: add zizmor#233
drmorr0 merged 1 commit intomainfrom
drmorr/zizmor

Conversation

@drmorr0
Copy link
Copy Markdown
Contributor

@drmorr0 drmorr0 commented Mar 30, 2026

Description and Rationale

  • install zizmor to make our security posture (slightly) better

How

Test Steps

  • testing the workflows on this PR (in progress)

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

@linear
Copy link
Copy Markdown

linear bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

@ogorman89 ogorman89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think the llvm error on the verify workflow is just a missing with: tool:

uses: taiki-e/install-action@0fde6d128a3d980ceac30be8c8b8739abd963b81 # v2.70.0
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
uses: taiki-e/install-action@0fde6d128a3d980ceac30be8c8b8739abd963b81 # v2.70.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Verify workflow failed because these lines (100 & 102) are pinned now. I think the fix is just something like:

 - name: Install cargo-nextest
    uses: taiki-e/install-action@0fde6d128a3d980ceac30be8c8b8739abd963b81  # v2.70.0
    with:
        tool: cargo-nextest
 - name: Install cargo-llvm-cov
    uses: taiki-e/install-action@0fde6d128a3d980ceac30be8c8b8739abd963b81  # v2.70.0
    with:
        tool: cargo-nextest

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (3d7dd95) to head (d85bc67).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files          63       63           
  Lines        3789     3789           
=======================================
  Hits         2982     2982           
  Misses        807      807           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drmorr0 drmorr0 merged commit ebabcdc into main Mar 31, 2026
9 checks passed
@drmorr0 drmorr0 deleted the drmorr/zizmor branch March 31, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants