Skip to content

fix[N10] Make better use of immutable #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2022
Merged

fix[N10] Make better use of immutable #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d13b8c5
fix[N10] Make better use of immutable
chrismaree Mar 16, 2022
7075898
code .Merge branch 'master' into chrismaree/n10
chrismaree Mar 18, 2022
cccb955
nit
chrismaree Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/HubPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,13 @@ contract HubPool is HubPoolInterface, Testable, Lockable, MultiCaller, Ownable {
mapping(uint256 => CrossChainContract) public crossChainContracts;

// WETH contract for Ethereum.
WETH9 public weth;
WETH9 public immutable weth;

// Helper factory to deploy new LP tokens for enabled L1 tokens
LpTokenFactoryInterface public lpTokenFactory;
LpTokenFactoryInterface public immutable lpTokenFactory;

// Finder contract for this network.
FinderInterface public finder;
FinderInterface public immutable finder;

// When root bundles are disputed a price request is enqueued with the DVM to resolve the resolution.
bytes32 public identifier = "IS_ACROSS_V2_BUNDLE_VALID";
Expand Down
2 changes: 1 addition & 1 deletion contracts/Optimism_SpokePool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ contract Optimism_SpokePool is CrossDomainEnabled, SpokePool {
uint32 public l1Gas = 5_000_000;

// ETH is an ERC20 on OVM.
address public l2Eth = address(Lib_PredeployAddresses.OVM_ETH);
address public immutable l2Eth = address(Lib_PredeployAddresses.OVM_ETH);

// Stores alternative token bridges to use for L2 tokens that don't go over the standard bridge. This is needed
// to support non-standard ERC20 tokens on Optimism, such as DIA and SNX which both use custom bridges.
Expand Down
2 changes: 1 addition & 1 deletion contracts/SpokePool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ abstract contract SpokePool is SpokePoolInterface, Testable, Lockable, MultiCall

// Address of WETH contract for this network. If an origin token matches this, then the caller can optionally
// instruct this contract to wrap ETH when depositing.
WETH9 public weth;
WETH9 public immutable weth;

// Any deposit quote times greater than or less than this value to the current contract time is blocked. Forces
// caller to use an approximately "current" realized fee. Defaults to 10 minutes.
Expand Down